laba01

main.cpp

@@ -1,141 +1,135 @@
 #include <iostream>
 #include <vector>
-#include <algorithm>
 
 using namespace std;
 
+struct Input
+{
+    vector<double> numbers;
+    size_t bin_count{};
+};
 
-int main()
+Input input_data()
 {
-    int g = 0;
     size_t number_count;
-    cerr<< "Enter number count: ";
-    cin >> number_count;//number_count êîë-âî îöåíîê íà âõîäå
-    vector<double> numbers(number_count);//number_count=10
+    cerr << "Enter number count: ";
+    cin >> number_count;
+
+    Input in;
+    in.numbers.resize(number_count);
 
-    for (size_t i = 0; i < number_count; i++)
+    vector<double> numbers(number_count);
+    for (int i = 0; i < number_count; i++)
     {
-        cin >> numbers[i]; // 4 4 3 5 3 4 5 5 4 4
+        cerr << "Number[" << i << "]=";
+        cin >> in.numbers[i];
     }
-    int bin_count;//bin_count êîë-âî êîðçèí
-    cerr << "Enter bin_count: ";
-    cin >> bin_count;
-    vector <size_t> bins(bin_count);//Íåîáõîäèìî äëÿ êàæäîé êîðçèíû ïîäñ÷èòàòü êîëè÷åñòâî ïîïàâøèõ â íåå ÷èñåë
-    double min = numbers[0];
-    double max = numbers[0];
+
+    cerr << "Enter bin count: ";
+    cin >> in.bin_count;
+    return in;
+}
+void find_minmax(const vector <double> &numbers, double &min, double &max)
+{
+    min = numbers[0];
+    max = numbers[0];
     for (double x : numbers)
     {
-        if (x < min) {
+        if (x < min)
+        {
             min = x;
         }
-        else if (x > max) {
+        else if (x > max)
+        {
             max = x;
         }
     }
+}
+vector<size_t> make_histogram(const vector<double> &numbers, size_t bin_count)
+{
+    double min, max;
+    find_minmax(numbers, min, max);
     double bin_size = (max - min) / bin_count;
-    bool found;
-    for (size_t i = 0; i < number_count; i++)
+    vector <size_t> bins (bin_count);
+
+    for (size_t i = 0; i < numbers.size(); i++)
     {
-        found = false;
-        for (size_t j = 0; (j <bin_count) && !found; j++)
+        bool found = false;
+        for (size_t j = 0; (j < bin_count - 1) && !found; j++)
         {
             auto lo = min + j * bin_size;
-            auto hi = min + (j + 1) * bin_size;
-            if ((lo <= numbers[i]) && (numbers[i] <=hi))
+            auto hi = min + (j+1) * bin_size;
+            if ((lo <= numbers[i]) && (numbers[i] < hi))
             {
                 bins[j]++;
                 found = true;
             }
         }
-    }
-    if (!found)
-    {
+        if (!found)
+        {
             bins[bin_count - 1]++;
-        //êîë-âî êîðçèí
+        }
     }
-  /*  for(int i=0;i<bin_count;i++)
+    return bins;
+}
+void show_histogram_text(const vector<size_t>& bins, size_t& bin_count, double bin_size)
+{
+    const size_t SCREEN_WIDTH = 80;
+    const size_t MAX_ASTERISK = SCREEN_WIDTH - 3 - 1;
+    size_t max_bin_count = bins[0];
+    for(size_t i = 0; i < bin_count; i++)
     {
-        cout<<bins[i]<<"|";
-        for(int j=0;j<bins[i];j++)
+        if(bins[i] > max_bin_count)
         {
-            cout<<"*";
+            max_bin_count = bins[i];
         }
-        cout<<endl;
     }
-*/
-   /*for(int i=0;i<bin_count;i++)
-    {   if(bins[i]>=100)
-        cout<<""<<bins[i]<<"|";
-        if (bins[i]<100 and bins[i]>10)
-        cout<<" "<<bins[i]<<"|";
-        if (bins[i]<10)
-        cout<<"  "<<bins[i]<<"|";
-        for(int j=0;j<bins[i];j++)
+
+    for(size_t i = 0; i < bin_count; i++)
+    {
+        if(bins[i]<10)
         {
-            cout<<"*";
+            cout<< "  " << bins[i] << "|";
         }
-     cout<<endl;
-    }*/
-int height;
-const size_t SCREEN_WIDTH = 80;
-const size_t MAX_ASTERISK = SCREEN_WIDTH - 3 - 1;
-double max_count=bins[0];
-
+        else
+        {
+            if(bins[i]<100)
+            {
+                cout<< " " << bins[i] << "|";
+            }
+            else
+            {
+                if(bins[i]<1000)
+                {
+                    cout<< bins[i] << "|";
+                }
 
-  /*  for(size_t x : bins)
-   {
-       if(max_count < x)
-       max_count=x;
-   }
-for(int i=0;i<bin_count;i++)
-    {
-         if(bins[i]>=100)
-        cout<<""<<bins[i]<<"|";
-        if (bins[i]<100 and bins[i]>10)
-        cout<<" "<<bins[i]<<"|";
-        if (bins[i]<10)
-        cout<<"  "<<bins[i]<<"|";
-    if(max_count<=MAX_ASTERISK)
-        height= MAX_ASTERISK;
-    else
-    {
-        height=MAX_ASTERISK*(static_cast<double>(bins[i])/max_count);
-    }
-    for(int j=0;j<height;j++)
-    {
-        cout<<"*";
-    }
-    cout<<endl;
-    }*/
+            }
+        }
 
-cout<<"height= ";
-cin>>height;
-int c=height/bin_count;
-for(int i=0;i<bin_count;i++)
-    {   if(bins[i]>=100)
-        cout<<""<<bins[i]<<"|";
-        if (bins[i]<100 and bins[i]>10)
-        cout<<" "<<bins[i]<<"|";
-        if (bins[i]<10)
-        cout<<"  "<<bins[i]<<"|";
-        for(int j=0;j<bins[i];j++)
+        size_t height;
+        if(max_bin_count <= MAX_ASTERISK)
         {
-            cout<<"*";
+            height = bins[i];
         }
-     cout<<endl;
-    for(int k=0;k<c-1;k++)
-    {   if(bins[i]>=100)
-        cout<<" "<<"|";
-        if (bins[i]<100 and bins[i]>10)
-        cout<<"  "<<"|";
-        if (bins[i]<10)
-        cout<<"   "<<"|";
-        for(int j=0;j<bins[i];j++)
+        else
+        {
+            height = MAX_ASTERISK * (static_cast<double>(bins[i]) / max_bin_count);
+        }
+        for(size_t j = 0; j < height;  j ++)
         {
             cout<<"*";
         }
-     cout<<endl;
-    }
+        cout<<endl;
     }
+}
+
+int main()
+{
+    Input in = input_data();
+    auto bins = make_histogram(in.numbers, in.bin_count);
+    double min, max;
+    double bin_size = (max - min) / in.bin_count;
+    show_histogram_text(bins,in.bin_count, bin_size);
     return 0;
 }