пойдет

main.cpp

@@ -1,75 +1,106 @@
 #include <iostream>
 #include <vector>
-#include <cmath>
+#include <limits>
+
 using namespace std;
 
-int main(){
-    const size_t SCREEN_WIDTH = 80;
-    const size_t MAX_ASTERISK = SCREEN_WIDTH - 3 - 1;
+const size_t SCREEN_WIDTH = 80;
+const size_t MAX_ASTERISK = SCREEN_WIDTH - 3 - 1;
+
+// Ñòðóêòóðà äëÿ âõîäíûõ äàííûõ
+struct Input {
+    vector<double> numbers;
+    size_t bin_count{};
+};
+
+// Ôóíêöèÿ ââîäà äàííûõ
+Input
+input_data() {
+    Input in;
     size_t number_count;
-    cerr << "Enter amount of numbers \n";
+
+    cerr << "Enter number count: ";
     cin >> number_count;
-    vector<double> numbers(number_count);
-    for (size_t i = 0; i < number_count; i++){
-        cerr << "Input number " << i+1 << endl;
-        cin >> numbers[i];
-    }
-    double minc, maxc;
-    minc = maxc = numbers[0];
-    for (size_t i = 1; i < number_count; i++ ){
-        if(numbers[i] < minc){
-            minc = numbers[i];
-        }
-        else if (numbers[i] > maxc){
-            maxc = numbers[i];
-        }
-    }
-    size_t bin_count;
-    cerr << "Input number of bins \n";
-    cin >> bin_count;
-    vector<size_t> bins(bin_count);
-    double bin_size = (maxc - minc) / bin_count;
-    size_t bin_max_size = 0;
+
+    in.numbers.resize(number_count);
+    cerr << "Enter " << number_count << " numbers: ";
     for (size_t i = 0; i < number_count; i++) {
-        bool found = false;
-        for (size_t j = 0; (j < bin_count - 1) && !found; j++) {
-            auto lo = minc + j * bin_size;
-            auto hi = minc + (j + 1) * bin_size;
-            if ((lo <= numbers[i]) && (numbers[i] < hi)) {
-                bins[j]++;
-                found = true;
-                if (bins[j]> bin_max_size){
-                    bin_max_size = bins[j];
-                }
-            }
-        }
-        if (!found) {
-            bins[bin_count - 1]++;
-            if (bins[bin_count - 1]> bin_max_size){
-                    bin_max_size = bins[bin_count - 1];
+        cin >> in.numbers[i];
     }
+
+    cerr << "Enter bin count: ";
+    cin >> in.bin_count;
+
+    return in;
+}
+
+// Ôóíêöèÿ ïîèñêà ìèíèìóìà è ìàêñèìóìà
+void
+find_minmax(const vector<double>& numbers, double& min, double& max) {
+    min = numeric_limits<double>::max();
+    max = numeric_limits<double>::lowest();
+
+    for (double x : numbers) {
+        if (x < min) min = x;
+        if (x > max) max = x;
     }
+}
+
+// Ôóíêöèÿ ñîçäàíèÿ ãèñòîãðàììû
+vector<size_t>
+make_histogram(const vector<double>& numbers, size_t bin_count) {
+    double min, max;
+    find_minmax(numbers, min, max);
+
+    if (max == min) {
+        return vector<size_t>(bin_count, numbers.size());
     }
-    size_t height;
-    for(int i = 0; i<bin_count; i++){
-        if(bins[i]<100){
-            cout<<" ";
-            if(bins[i]<10){
-                cout<<" ";
+
+    double bin_size = (max - min) / bin_count;
+    vector<size_t> bins(bin_count, 0);
+
+    for (double x : numbers) {
+        size_t bin_index = static_cast<size_t>((x - min) / bin_size);
+        if (bin_index >= bin_count) bin_index = bin_count - 1;
+        bins[bin_index]++;
     }
+
+    return bins;
+}
+
+// Ôóíêöèÿ âûâîäà ãèñòîãðàììû
+void
+show_histogram_text(const vector<size_t>& bins) {
+    size_t max_count = 0;
+    for (size_t count : bins) {
+        if (count > max_count) max_count = count;
     }
-        cout<<bins[i]<<"|";
-        if(bin_max_size >= MAX_ASTERISK){
-            height = floor(static_cast<double>(bins[i])*76.0f/static_cast<double>(bin_max_size));
+
+    cerr << "Bin counts:" << endl;
+
+    for (size_t j = 0; j < bins.size(); j++) {
+        size_t height = (max_count > MAX_ASTERISK)
+            ? static_cast<size_t>(MAX_ASTERISK * (static_cast<double>(bins[j]) / max_count))
+            : bins[j];
+
+        if (bins[j] < 10) {
+            cout << "  " << bins[j] << "|";
+        } else if (bins[j] < 100) {
+            cout << " " << bins[j] << "|";
         } else {
-            height = bins[i];
-        }
-        for(int j = 0; j<height; j++){
-            cout<<"*";
+            cout << bins[j] << "|";
         }
 
-        cout<<endl;
+        for (size_t k = 0; k < height; k++) cout << "*";
+        cout << endl;
     }
+}
+
+int
+main() {
+    auto in = input_data();
+    auto bins = make_histogram(in.numbers, in.bin_count);
+    show_histogram_text(bins);
 
     return 0;
 }