histogram.cpp

@@ -2,20 +2,14 @@
 #include <conio.h>
 #include <vector>
 #include <stdlib.h>
-#include "histogram.h"
-
 using namespace std;
+#include "histogram.h"
 
-bool
+void
 find_minmax(const vector<double>& numbers, double& min, double& max){
-    if (numbers.empty()){
-        return false;
-    }
-
     min = numbers[0];
-    max = numbers[0];
+    min = numbers[0];
-    for(size_t i=0; i < numbers.size(); i++)
+    for(size_t i=0; i < numbers.size(); i++){
-    {
         if (numbers[i] < min)
         {
             min = numbers[i];
@@ -25,8 +19,6 @@ find_minmax(const vector<double>& numbers, double& min, double& max){
             max = numbers[i];
         }
     }
-
-    return true;
 }
 
 

histogram_internal.h

@@ -1,8 +0,0 @@
-#ifndef HISTOGRAM_INTERNAL_H_INCLUDED
-#define HISTOGRAM_INTERNAL_H_INCLUDED
-
-#include <vector>
-bool
-find_minmax(const std::vector<double>& numbers, double& min, double& max);
-
-#endif // HISTOGRAM_INTERNAL_H_INCLUDED

unittest.cpp

@@ -14,7 +14,9 @@ TEST_CASE("distinct positive numbers") {
 TEST_CASE("empty vector"){
     double min = 0;
     double max = 0;
-    CHECK(!find_minmax({}, min, max));
+    find_minmax({ NULL }, min, max);
+    CHECK(min == 0);
+    CHECK(max == 0);
 }
 
 TEST_CASE("same elements"){
@@ -22,6 +24,7 @@ TEST_CASE("same elements"){
     double max = 0;
     find_minmax({ 1, 1 }, min, max);
     CHECK(min == max);
+    CHECK(max == min);
 }
 
 TEST_CASE("only one number"){