структурирование программы при помощи функций

main.cpp

@@ -1,106 +1,131 @@
 #include <iostream>
 #include <vector>
 using namespace std;
-int main()
+
+struct Input
 {
-    setlocale(LC_ALL, "rus");
-    const size_t SCREEN_WIDTH = 80;
-    const size_t MAX_ASTERISK = SCREEN_WIDTH - 3 - 1;
-    size_t number_count,bin_count;
-    cerr << "Ââåäèòå êîëè÷åñòâî çíà÷åíèé: "; cin >> number_count;
+    vector<double> numbers;
+    size_t bin_count{};
+};
 
-    vector<double> number(number_count);
-    for (int i = 0; i < number_count; i++)
+Input input_data()
+{
+    Input in;
+    size_t number_count;
+    cin >> number_count;
+    in.numbers.resize(number_count);
+
+    vector<double> numbers(number_count);
+    for (size_t i = 0; i < number_count; i++)
     {
-        cerr << "Ââåäèòå ÷èñëî ïîä íîìåðîì " << i + 1 << " "; cin >> number[i];
+        cin >> in.numbers[i];
     }
-    cerr << "Ââåäèòå êîëè÷åñòâî êîðçèí: "; cin >> bin_count;
-    vector<size_t> bins(bin_count);
-    double min = number[0];
-    double max = number[0];
-    size_t Maxbins = bins[0];
-    for (double x : number)
+    cin >> in.bin_count;
+    return in;
+}
+
+void find_minmax(const vector<double>& numbers, double& minN, double& maxN)
+{
+    minN = numbers[0];
+    maxN = numbers[0];
+    for (double x : numbers)
     {
-        if (x < min)
+        if (minN > x)
         {
-            min = x;
+            minN = x;
         }
-        else if (x > max)
+        if (maxN < x)
         {
-            max = x;
+            maxN = x;
         }
     }
-    double bin_size = (max - min) / bin_count;
-    for (size_t i = 0; i < number_count; i++)
+}
+
+vector<size_t> make_histogram(const vector<double>& numbers, size_t bin_count, size_t& max_count)
+{
+    double minN, maxN;
+    find_minmax(numbers, minN, maxN);
+    vector<size_t> bins(bin_count);
+    double diff = (maxN - minN) / bin_count;
+    max_count = 0;
+
+    for (size_t i = 0; i < numbers.size(); i++)
     {
         bool found = false;
-
         for (size_t j = 0; (j < bin_count - 1) && !found; j++)
         {
-            auto lo = min + j * bin_size;
-            auto hi = min + (j + 1) * bin_size;
-            if ((lo <= number[i]) && (number[i] < hi))
+            auto lo = minN + j * diff;
+            auto hi = minN + (j + 1) * diff;
+            if ((lo <= numbers[i]) && (hi > numbers[i]))
             {
                 bins[j]++;
+                if (bins[j] > max_count)
+                    max_count = bins[j];
                 found = true;
             }
-
         }
-
         if (!found)
         {
             bins[bin_count - 1]++;
+            if (bins[bin_count - 1] > max_count)
+                max_count = bins[bin_count - 1];
         }
     }
-    for (int i = 0; i < bin_count; i++)
-    {
-        if (bins[i] > Maxbins)
-        {
-            Maxbins = bins[i];
-        }
-    }
+    return bins;
+}
+
+void show_histogram_text(const vector<size_t>& bins, size_t bin_count, size_t max_count)
+{
+    const size_t SCREEN_WIDTH = 80;
+    const size_t MAX_ASTERISK = SCREEN_WIDTH - 3 - 1;
 
-    if (Maxbins <= 76)
+    bool scaling = false;
+    if (max_count > MAX_ASTERISK)
     {
-        for (int i = 0; i < bins.size(); i++)
+        scaling = true;
+    }
+    for (size_t i = 0; i < bin_count; i++)
     {
         if (bins[i] < 10)
         {
             cout << "  ";
         }
-            cout << " " << bins[i] << "|";
-            for (int j = 0; j < bins[i]; j++)
+        else if (bins[i] < 100)
         {
-                cout << "*";
-            }
-            cout << endl;
-
-
-
-        }
+            cout << " ";
         }
         else
         {
-        for (int i = 0; i < bins.size(); i++)
+            cout << "";
+        }
+        cout << bins[i] << '|';
+
+        size_t number_of_stars = bins[i];
+
+        if (scaling)
         {
-            size_t height = MAX_ASTERISK * (static_cast<double>(bins[i]) / Maxbins);
-            if (bins[i] < 100)
+            if (bins[i] == max_count)
             {
-                cout << " ";
+                number_of_stars = MAX_ASTERISK;
             }
-            if (bins[i] < 10)
+            else
             {
-                cout << " ";
+                number_of_stars = MAX_ASTERISK * (static_cast<double>(bins[i]) / max_count);
             }
-            cout << bins[i] << "|";
-            for (int j = 0; j < height; j++)
-            {
-                cout << "*";
         }
-            cout << endl;
-
-
 
+        for (size_t j = 0; j < number_of_stars; j++)
+        {
+            cout << '*';
         }
+        cout << endl;
     }
 }
+
+int main()
+{
+    size_t max_count;
+    auto in = input_data();
+    auto bins = make_histogram(in.numbers, in.bin_count, max_count);
+    show_histogram_text(bins, in.bin_count, max_count);
+}