code: вывод гистограммы

main.cpp

@@ -2,41 +2,61 @@
 #include <vector>
 
 using namespace std;
-int main() {
-    const size_t SCREEN_WIDTH = 80;
-    const size_t MAX_ASTERISK = SCREEN_WIDTH - 3 - 1;
+
+struct Input {
+    vector<double> numbers;
+    size_t bin_count{};
+};
+
+Input
+input_data() {
     size_t number_count;
-    size_t max_count = 0;
     cerr << "Enter number count: ";
     cin >> number_count;
-    vector<double> numbers(number_count);
-    cerr << "Enter numbers:";
-    for (int i = 0; i < number_count; i++) {
-        cin >> numbers[i];
+    Input in;
+    in.numbers.resize(number_count);
+    for (size_t i = 0; i < number_count; i++)
+    {
+        cin >> in.numbers[i];
     }
-
-
-    size_t bin_count;
     cerr << "Enter bin count: ";
-    cin >> bin_count;
-    vector<size_t> bins(bin_count);
-    double min = numbers[0];
-    double max = numbers[0];
-    for (double x : numbers) {
-        if (x < min) {
+    cin >> in.bin_count;
+    return in;
+}
+void
+find_minmax(const vector<double>& numbers, double& min, double& max)
+{
+    min = numbers[0];
+    max = numbers[0];
+    for (double x : numbers)
+    {
+        if (x > max )
+        {
+            max = x;
+        }
+        if (x < min)
+        {
             min = x;
         }
-        else if (x > max) {
-            max = x;
     }
 }
-    double bin_size = (max - min) / bin_count;
-    for (size_t i = 0; i < number_count; i++) {
+vector<size_t>
+make_histogram(const vector<double>& numbers, size_t& bin_count)
+{
+    double min = 0;
+    double max = 0;
+    find_minmax(numbers, min, max);
+    auto bin_size = (max - min)/bin_count;
+    vector<size_t> bins(bin_count);
+    for (double number : numbers)
+    {
         bool found = false;
-        for (size_t j = 0; (j < bin_count - 1) && !found; j++) {
+        for (size_t j = 0; (j < bin_count - 1) && !found; j++)
+        {
              auto lo = min + j * bin_size;
              auto hi = min + (j + 1) * bin_size;
-            if ((lo <= numbers[i]) && (numbers[i] < hi)) {
+             if ((lo <= number) && (number < hi))
+            {
                 bins[j]++;
                 found = true;
             }
@@ -44,29 +64,50 @@ int main() {
         if (!found) {
             bins[bin_count - 1]++;
         }
-        for (size_t i = 0; i < bin_count; i++) {
-            if (bins[i] > max_count) {
-                max_count = bins[i];
     }
+    return bins;
 }
+void
+show_histogram_text(const vector<size_t>& bins, size_t& bin_count) {
+    const size_t SCREEN_WIDTH = 80;
+    const size_t MAX_ASTERISK = SCREEN_WIDTH - 3 - 1;
+    size_t max_count = 0;
+    for (size_t s = 0; s < bin_count; s++)
+    {
+        if (bins[s] > max_count)
+        {
+            max_count = bins[s];
         }
-    double kof = double(MAX_ASTERISK) / max_count;
-    if (kof > 1) {
-        kof = 1;
     }
-    for (size_t bin : bins) {
-        if (bin < 100) {
+    for (size_t bin : bins)
+    {
+        if (bin <100)
+        {
             cout << " ";
         }
-        if (bin < 10) {
+        if (bin <10)
+        {
             cout << " ";
         }
         cout << bin << "|";
-        for (size_t i = 0; i < size_t(bin * kof); i++) {
+        if (max_count > MAX_ASTERISK)
+        {
+            size_t count = bin;
+            size_t height = MAX_ASTERISK * (static_cast<double>(count) / max_count);
+            for (size_t t = 0; t < height; t++)
+            {
+                cout << "*";
+            }
+        }
+         else for (size_t k = 0; k < bin; k++)
+            {
                 cout << "*";
             }
-
         cout << endl;
     }
-    return 0;
+}
+int main() {
+    Input in = input_data();
+    vector<size_t> bins = make_histogram(in.numbers, in.bin_count);
+    show_histogram_text(bins, in.bin_count);
 }