main.cpp

@@ -2,114 +2,101 @@
 #include <vector>
 using namespace std;
 
-struct Input {
+int main(){
-    vector<double> numbers;
+    const size_t SCREEN_WIDTH = 80;
-    size_t bin_count{};
+    const size_t MAX_ASTERISK = SCREEN_WIDTH - 3 - 1;
-};
-
-Input
-input_data() {
-    Input in;
 
-    cerr << "Enter number count: ";
    size_t number_count;
+   cerr << "enter number count";
    cin >> number_count;
 
-    in.numbers.resize(number_count);
+   vector<double> numbers(number_count);
-    for (size_t i = 0; i < number_count; i++) {
+   cerr << "put elements with enter";
-        cin >> in.numbers[i];
+   for (int i = 0; i<number_count; i++){
+        cin >> (numbers[i]);
    }
 
-    cerr << "Enter number bin: ";
+   size_t bin_count;
-    cin >> in.bin_count;
+   cerr << "enter bin count";
+   cin >> bin_count;
 
-    return in;
+   vector<size_t> bins(bin_count);
-}
 
-void find_minmax(const vector<double>& numbers, double& min, double& max) {
+   double min = numbers[0];
-    min = numbers[0];
+   double max = numbers[0];
-    max = numbers[0];
+   for (double x: numbers){
-    for (double x : numbers)
+        if (x < min){
-    {
-        if (x < min)
-        {
             min = x;
-        }
+        } else if (x > max) {
-        else if (x > max)
-        {
             max = x;
         }
    }
-}
-vector<size_t>
-make_histogram(const vector<double>& numbers, size_t bin_count) {
-    double min, max;
-    find_minmax(numbers, min, max);
 
-    vector<size_t> bins(bin_count);
+   double bin_size = (max - min)/bin_count;
-    double bin_size = (max - min) / bin_count;
 
-    for (size_t i = 0; i < numbers.size(); i++) {
+   for (size_t i = 0; i<number_count; i++){
         bool found = false;
-        for (size_t j = 0; (j < bin_count - 1) && !found; j++) {
+        for (size_t j = 0; (j<bin_count-1) && !found; j++){
-            auto lo = min + j * bin_size;
+            auto lo = min+j*bin_size;
-            auto hi = min + (j + 1) * bin_size;
+            auto hi = min+(j+1)*bin_size;
-            if ((lo <= numbers[i]) && (numbers[i] < hi)) {
+            if ((lo <= numbers[i]) && (numbers[i] < hi)){
                 bins[j]++;
                 found = true;
             }
         }
-        if (!found) {
+        if (!found){
-            bins[bin_count - 1]++;
+            bins[bin_count-1]++;
         }
    }
-    return bins;
-}
 
-void show_histogram_text(const vector<size_t>& bins, size_t max_count, size_t MAX_ASTERISK, size_t bin_count){
+    size_t max_count = bins[0];
-     for (size_t i = 0; i < bin_count; i++){
+   double widght = bins[0];
-        if (bins[i]<10) {
+   for (double x: bins){
-            cout << "  " << bins[i] << "|";
+      if (x > widght) {
+            widght = x;
         }
-        else if (bins[i]<100) {
-            cout << " " << bins[i] << "|";
    }
-        else if (bins[i]<1000) {
+    cout << "+";
-            cout << bins[i] << "|";
+    for (int i=0; i<widght+5; i++){
+        cout << "-";
     }
+    cout << "+" << endl;
 
-        size_t height;
+    for (int i = 0; i<bin_count; i++){
+        if (bins[i] > max_count){
+            max_count = bins[i];
+        }
+    }
+        for (int i = 0; i<bin_count; i++){
+        if (bins[i] < 10){
+                cout << "|" << "  " << bins[i] << "|";}
+        else if (bins[i]>=10 && bins[i]<100){
+             cout << "|" << " " << bins[i] << "|";
+        }
+        else if (bins[i]>=100 && bins[i]<1000){
+             cout << "|" << bins[i] << "|";
+        }
 
-        if (max_count<=MAX_ASTERISK) {
+        size_t height;
+        if (max_count <= MAX_ASTERISK){
             height = bins[i];
         }
-        else {
+        else{
-            height = MAX_ASTERISK * (static_cast<double>(bins[i]) / max_count);
+            height = MAX_ASTERISK*(static_cast<double>(bins[i])/max_count);
         }
-        for (size_t j = 0; j < height; j++) {
+        for (int j = 0; j<height; j++){
                 cout << "*";
             }
+            cout << " " << "|";
             cout << endl;
     }
 
-}
+    cout << "+";
-
+    for (int i=0; i<widght+5; i++){
-int main()
+        cout << "-";
-{
-    const size_t SCREEN_WIDTH = 80;
-    const size_t MAX_ASTERISK = SCREEN_WIDTH - 3 - 1;
-
-    auto in = input_data();
-    auto bins = make_histogram(in.numbers, in.bin_count);
-
-
-    size_t max_count = bins[0];
-    for (size_t i = 0; i < bins.size(); i++) {
-        if (bins[i] > max_count) {
-            max_count = bins[i];
-        }
     }
-    show_histogram_text(bins, max_count, MAX_ASTERISK, in.bin_count);
+    cout << "+" << endl;
+
 
    return 0;
 }