histogram.cpp

@@ -2,15 +2,9 @@
 #include <vector>
 using namespace std;
 
-void find_minmax(const vector<double>& numbers, double& min, double& max) {
+static void find_minmax(const vector<double>& numbers, double& min, double& max) {
-    if (numbers.empty())
-    {
-        min = 0;
-        max = 0;
-        return;
-    }
     max = numbers[0];
-    min = numbers[0];
+    min = numbers[1];
     for (double x : numbers) {
         if (x < min) min = x;
         else if (x > max) max = x;

histogram_internal.h

@@ -1,7 +0,0 @@
-#ifndef HISTOGRAM_INTERNAL_H_INCLUDED
-#define HISTOGRAM_INTERNAL_H_INCLUDED
-
-void find_minmax(const std::vector<double>& numbers, double& min, double& max);
-
-#endif
-

unittest.cpp

@@ -1,44 +0,0 @@
-#define DOCTEST_CONFIG_NO_MULTITHREADING
-#define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
-#include "doctest.h"
-#include "histogram_internal.h"
-
-TEST_CASE("distinct positive numbers") {
-    double min = 0;
-    double max = 0;
-    find_minmax({1, 2}, min, max);
-    CHECK(min == 1);
-    CHECK(max == 2);
-}
-
-
-TEST_CASE("distinct negative numbers"){
-    double min = 0;
-    double max = 0;
-    find_minmax({-1, -2}, min, max);
-    CHECK(min == -2);
-    CHECK(max == -1);
-}
-TEST_CASE("vector of the same elements"){
-    double min = 0;
-    double max = 0;
-    find_minmax({3,3,3}, min, max);
-    CHECK(min == 3);
-    CHECK(max == 3);
-}
-
-TEST_CASE("single element vector") {
-    double min = 0;
-    double max = 0;
-    find_minmax({7}, min, max);
-    CHECK(min == 7);
-    CHECK(max == 7);
-}
-
-TEST_CASE("empty vector") {
-    double min = 0;
-    double max = 0;
-    find_minmax({}, min, max);
-    CHECK(min == 0);
-    CHECK(max == 0);
-}