code: заменил поток cin на выборочный поток

project/histogram.cpp

@@ -2,42 +2,62 @@
 #include <vector>
 #include "histogram.h"
 using namespace std;
-void
-find_minmax(vector<double> numbers, double& min, double& max) {
-    min = numbers[0];
-    max = numbers[0];
-    for (double x : numbers) {
-    if (x < min) {
-        min = x;
+bool
+find_minmax(vector<double> numbers, double& min, double& max)
+{
+    bool check;
+    if(numbers.size()==0)
+    {
+
+        check = false;
     }
-    else if (x > max) {
-        max = x;
+    else
+    {
+        min = numbers[0];
+        max = numbers[0];
+        for (double x : numbers)
+        {
+            if (x < min)
+            {
+                min = x;
+            }
+            else if (x > max)
+            {
+                max = x;
+            }
+        }
     }
-}
+   return check;
 }
 
 vector<size_t>
-make_histogram(vector<double> numbers, size_t bin_count) {
+make_histogram(vector<double> numbers, size_t bin_count)
+{
     vector <size_t> bins(bin_count);
     double min, max;
-    find_minmax(numbers, min, max);
+    bool check;
+    check = find_minmax(numbers, min, max);
     size_t countt;
     double bin_size = (max - min) / bin_count;
-    for (size_t i = 0; i < numbers.size(); i++) {
-    bool found = false;
-    for (size_t j = 0; (j < bin_count - 1) && !found; j++) {
-        auto lo = min + j * bin_size;
-        auto hi = min + (j + 1) * bin_size;
-        if ((lo <= numbers[i]) && (numbers[i] < hi)) {
-            bins[j]++;
-            found = true;
+    for (size_t i = 0; i < numbers.size(); i++)
+    {
+        bool found = false;
+        for (size_t j = 0; (j < bin_count - 1) && !found; j++)
+        {
+            auto lo = min + j * bin_size;
+            auto hi = min + (j + 1) * bin_size;
+            if ((lo <= numbers[i]) && (numbers[i] < hi))
+            {
+                bins[j]++;
+                found = true;
+            }
+        }
+        if (!found)
+        {
+            bins[bin_count - 1]++;
         }
     }
-        if (!found) {
-        bins[bin_count - 1]++;
-    }
-    }
-        return bins;
+    return bins;
 
 
 }

project/main.cpp

@@ -3,29 +3,33 @@
 #include "histogram.h"
 #include "text.h"
 #include "svg.h"
+#include "emptiness.h"
 using namespace std;
-struct Input {
+struct Input
+{
     vector<double> numbers;
     size_t bin_count{};
 };
 
 Input
-input_data(){
+input_data(istream& tin)
+{
     size_t number_count;
     cerr << "Enter number count: ";
-    cin >> number_count;
+    tin >> number_count;
     Input in;
     in.numbers.resize(number_count);
-    for(int i;i<number_count;i++)
+    for(int i; i<number_count; i++)
     {
-        cin >> in.numbers[i];
+        tin >> in.numbers[i];
     }
     cerr << "Enter bin count: ";
-    cin >> in.bin_count;
+    tin >> in.bin_count;
     return in;
 }
 int main()
-{   Input in = input_data();
+{
+    Input in = input_data(cin);
     auto bins = make_histogram(in.numbers, in.bin_count);
     show_histogram_svg(bins);
     return 0;

project/project.cbp

@@ -32,7 +32,31 @@
 			<Add option="-Wall" />
 			<Add option="-fexceptions" />
 		</Compiler>
+		<Unit filename=".gitignore" />
+		<Unit filename="emptiness.cpp" />
+		<Unit filename="emptiness.h">
+			<Option target="&lt;{~None~}&gt;" />
+		</Unit>
+		<Unit filename="histogram.cpp" />
+		<Unit filename="histogram.h">
+			<Option target="&lt;{~None~}&gt;" />
+		</Unit>
+		<Unit filename="histogram_internal.h">
+			<Option target="&lt;{~None~}&gt;" />
+		</Unit>
 		<Unit filename="main.cpp" />
+		<Unit filename="svg.cpp" />
+		<Unit filename="svg.h">
+			<Option target="&lt;{~None~}&gt;" />
+		</Unit>
+		<Unit filename="tasktest.h">
+			<Option target="&lt;{~None~}&gt;" />
+		</Unit>
+		<Unit filename="test.cpp" />
+		<Unit filename="text.cpp" />
+		<Unit filename="text.h">
+			<Option target="&lt;{~None~}&gt;" />
+		</Unit>
 		<Extensions />
 	</Project>
 </CodeBlocks_project_file>

project/svg.cpp

@@ -4,6 +4,7 @@
 #include <vector>
 #include <string>
 #include "svg.h"
+#include "emptiness.h"
 using namespace std;
 
 void
@@ -41,7 +42,7 @@ show_histogram_svg(const vector<size_t>& bins) {
     const auto TEXT_WIDTH = 50;
     const auto BIN_HEIGHT = 30;
     const auto BLOCK_WIDTH = 10;
-    const auto MAX_WIDTH = IMAGE_WIDTH-TEXT_WIDTH;
+    const double MAX_WIDTH = IMAGE_WIDTH-TEXT_WIDTH;
 
 
     svg_begin(IMAGE_WIDTH,IMAGE_HEIGHT);
@@ -54,8 +55,7 @@ double max_count = bins[0];
     }
     for (size_t bin : bins) {
         const double bin_width = MAX_WIDTH * (bin/max_count);
-        const double emptiness_width = MAX_WIDTH - bin_width;
-        svg_rect(0, top, emptiness_width, BIN_HEIGHT, "white", "#ffffff");
+        double emptiness_width = emptiness(MAX_WIDTH,bin_width);
         svg_text(TEXT_LEFT + MAX_WIDTH, top + TEXT_BASELINE, to_string(bin));
         svg_rect(emptiness_width, top, bin_width, BIN_HEIGHT, "red", "#aaffaa");
         top += BIN_HEIGHT;

unittest.cpp

@@ -1,16 +1,38 @@
 #define DOCTEST_CONFIG_NO_MULTITHREADING
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "doctest.h"
+#include "project\emptiness.h"
 #include "project\histogram_internal.h"
 
-TEST_CASE("distinct positive numbers") {
+TEST_CASE("difference check") {
+    double a = 20;
+    double b = 10;
+    double c = emptiness(a,b);
+    CHECK(c == 10);
+    CHECK(c > 0);
+    }
+TEST_CASE("more then 0 check") {
+    double a = 20;
+    double b = 10;
+    double c = emptiness(a,b);
+    CHECK(c > 0);
+    }
+TEST_CASE("less then 0 check") {
+    double a = 10;
+    double b = 20;
+    double c = emptiness(a,b);
+    CHECK(c < 0);
+    }
+TEST_CASE("not 0 check") {
+    double a = 20;
+    double b = 10;
+    double c = emptiness(a,b);
+    CHECK(c != 0);
+    }
+TEST_CASE("is massif full") {
     double min = 0;
     double max = 0;
-    std::vector<double>v{2,1};
-    CHECK(v.size() != 0);
-    CHECK(v.size() != 1);
-    find_minmax({1, 2}, min, max);
-    CHECK(min == 1);
-    CHECK(max == 2);
-    CHECK(min != max);
-}
+    std::vector<double>v{};
+    bool c = find_minmax(v,min,max);
+    CHECK(c == false);
+    }