From fa9fc93b8a241f446925e7a4bc601eae7be6b9bb Mon Sep 17 00:00:00 2001
From: "Alice (TimoshenkoAA)" <timoshenkoaa@mpei.ru>
Date: Sat, 27 Apr 2024 17:42:22 +0300
Subject: [PATCH] =?UTF-8?q?code:=D0=B4=D0=BE=D0=B1=D0=B0=D0=B2=D0=BB=D0=B5?=
 =?UTF-8?q?=D0=BD=D1=8B=20=D1=84=D1=83=D0=BD=D0=BA=D1=86=D0=B8=D0=B8?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 lab01/main.cpp | 92 +++++++++++++++++++++++++++-----------------------
 1 file changed, 50 insertions(+), 42 deletions(-)

diff --git a/lab01/main.cpp b/lab01/main.cpp
index 29fee08..501f694 100644
--- a/lab01/main.cpp
+++ b/lab01/main.cpp
@@ -2,22 +2,31 @@
 #include <iostream>
 #include <string>
 using namespace std;
-int main()
-{
-    const size_t SCREEN_WIDTH = 80;
-    const size_t MAX_ASTERISK = SCREEN_WIDTH - 3 - 1;
-    size_t number_count, bin_count, i, j;
+struct Input {
+    vector<double> numbers;
+    size_t bin_count {};
+};
+
+Input
+input_data() {
+    size_t number_count;
     cerr << "Enter number count: ";
     cin >> number_count;
-    vector<double> numbers(number_count);
+
+    Input in;
+    in.numbers.resize(number_count);
     cerr << "Enter numbers: ";
-    for (i = 0; i < number_count; i++) cin >> numbers[i];
+    for (size_t i = 0; i < number_count; i++) {
+        cin >> in.numbers[i];
+    }
     cerr << "Enter bin count: ";
-    cin >> bin_count;
-    vector<size_t> bins(bin_count);
-
-    double min = numbers[0];
-    double max = numbers[0];
+    cin >> in.bin_count;
+    return in;
+}
+void
+find_minmax(const vector<double>& numbers, double& min, double& max) {
+    min = numbers[0];
+    max = numbers[0];
     for (double x : numbers) {
         if (x < min) {
             min = x;
@@ -26,12 +35,18 @@ int main()
                 max = x;
         }
     }
+}
+vector <double>
+make_histogram(const vector<double>& numbers, size_t bin_count){
+    vector<double> bins (bin_count);
+    double min = 0, max = 0;
+    find_minmax(numbers, min, max);
 
     double bin_size = (max - min) / bin_count;
+    for (int i = 0; i < numbers.size(); i++) {
 
-    for (i = 0; i < number_count; i++) {
             bool found = false;
-            for (j = 0; (j < bin_count - 1) && !found; j++) {
+            for (int j = 0; (j < bin_count - 1) && !found; j++) {
                 auto lo = min + j * bin_size;
                 auto hi = min + (j + 1) * bin_size;
                 if ((lo <= numbers[i]) && (numbers[i] < hi)) {
@@ -42,44 +57,37 @@ int main()
             if (!found) {
                 bins[bin_count - 1]++;
             }
-    }
+        }
+    return bins;
+}
+
+void
+show_histogram_text (const vector<double>& bins,size_t MAX_ASTERISK, size_t bin_count){
+
     double max_count = bins[0];
     for (double x: bins){
         if (x > max_count) {
             max_count = x;
         }
     }
-    size_t sum_height = 0;
-    for (i=0; i<bin_count ; i++){
+    for (int i = 0; i < bin_count; i++){
         double count = bins[i];
         size_t height = MAX_ASTERISK * (static_cast<double>(count) / max_count);
-        sum_height = sum_height + height;
-    }
-    size_t av_height=sum_height/bin_count;
-
-    for (i=0; i<bin_count; i++){
-        if (bins[i]<100){
-            cout << ' ';
-        }
-        if (bins[i]<10){
-           cout << ' ';
-        }
-        double count = bins[i];
-        size_t height = MAX_ASTERISK * (static_cast<double>(count) / max_count);
-        if (height < av_height){
-           string lineAd (av_height - height , '-');
-           string line (height , '*');
-           cout << bins[i] << "|" << line << lineAd << endl;
-        }
-        if (height > av_height){
-           string lineAd (height - av_height , '+');
-           string line (av_height , '*');
-           cout << bins[i] << "|" << line << lineAd << endl;
-        }
-        if (height == av_height){
         string line (height , '*');
+        if (bins[i]<100)
+            {cout << ' ';}
+        if (bins[i]<10)
+        {cout << ' ';}
         cout << bins[i] << "|" << line << endl;
-        }
     }
+    }
+int main()
+{
+    const size_t SCREEN_WIDTH = 80;
+    const size_t MAX_ASTERISK = SCREEN_WIDTH - 3 - 1;
+
+    auto in = input_data();
+    auto bins = make_histogram(in.numbers, in.bin_count);
+    show_histogram_text(bins, MAX_ASTERISK, in.bin_count);
     return 0;
 }