From ab6b91d81f7db324456f4cf7e39d724d31b0aefa Mon Sep 17 00:00:00 2001
From: GaidaiAS <GaidaiAS@mpei.ru>
Date: Thu, 1 May 2025 23:41:37 +0300
Subject: [PATCH] =?UTF-8?q?=D0=B4=D0=BE=D0=B1=D0=B0=D0=B2=D0=BB=D0=B5?=
 =?UTF-8?q?=D0=BD=D0=B0=20=D0=BF=D0=BE=D0=B4=D0=BF=D1=80=D0=BE=D0=B3=D1=80?=
 =?UTF-8?q?=D0=B0=D0=BC=D0=BC=D0=B0=20find=5Fminmax?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 main.cpp | 71 ++++++++++++++++++++++++++++----------------------------
 1 file changed, 35 insertions(+), 36 deletions(-)

diff --git a/main.cpp b/main.cpp
index a7864a0..40875a8 100644
--- a/main.cpp
+++ b/main.cpp
@@ -5,44 +5,31 @@
 #include <cmath>
 using namespace std;
 
-int main() {
-    srand(42);
+struct Input {
+    vector<double> numbers;
+    size_t bin_count{};
+};
 
-    const size_t SCREEN_WIDTH = 80;
-    const size_t MAX_ASTERISK = SCREEN_WIDTH - 3 - 1;
+Input
+input_data() {
+    Input in;
     size_t number_count;
     cerr << "Enter number count: ";
     cin >> number_count;
-
-    string choice;
-    cerr << "Generate numbers?: ";
-    cin >> choice;
-
-    vector<double> numbers(number_count);
-    if (choice == "yes") {
-        for (size_t i = 0; i < number_count; i++) {
-            numbers[i] = 0;
-            for (int j = 0; j < 12; j++) {
-                numbers[i] += rand();
-            }
-        }
-    }
-    else
-    {
-        cerr << "Enter numbers: ";
-        for (size_t i = 0; i < number_count; i++) {
-            cin >> numbers[i];
-        }
+    in.numbers.resize(number_count);
+    for (size_t i = 0; i < number_count; i++) {
+        cin >> in.numbers[i];
     }
-
     size_t bin_count;
     cerr << "Enter bin count: ";
-    cin >> bin_count;
-
-    vector<size_t> bins(bin_count, 0);
+    cin >> in.bin_count;
+    return in;
+}
 
-    double min = numbers[0];
-    double max = numbers[0];
+void
+find_minmax(const vector<double>& numbers, double& min, double& max) {
+    min = numbers[0];
+    max = numbers[0];
     for (double x : numbers) {
         if (x < min) {
             min = x;
@@ -51,21 +38,33 @@ int main() {
             max = x;
         }
     }
+}
 
-    double bin_size = (max - min) / bin_count;
 
-    for (size_t i = 0; i < number_count; i++) {
+int main() {
+    const size_t SCREEN_WIDTH = 80;
+    const size_t MAX_ASTERISK = SCREEN_WIDTH - 3 - 1;
+    Input in = input_data();
+    vector<size_t> bins(in.bin_count, 0);
+
+    double min, max;
+    find_minmax(in.numbers, min, max);
+
+
+    double bin_size = (max - min) / in.bin_count;
+
+    for (size_t i = 0; i < in.numbers.size(); i++) {
         bool found = false;
-        for (size_t j = 0; (j < bin_count - 1) && !found; j++) {
+        for (size_t j = 0; (j < in.bin_count - 1) && !found; j++) {
             auto lo = min + j * bin_size;
             auto hi = min + (j + 1) * bin_size;
-            if ((lo <= numbers[i]) && (numbers[i] < hi)) {
+            if ((lo <= in.numbers[i]) && (in.numbers[i] < hi)) {
                 bins[j]++;
                 found = true;
             }
         }
         if (!found) {
-            bins[bin_count - 1]++;
+            bins[in.bin_count - 1]++;
         }
     }
 
@@ -76,7 +75,7 @@ int main() {
         }
     }
 
-    for (size_t i = 0; i < bin_count; i++) {
+    for (size_t i = 0; i < in.bin_count; i++) {
         cout << bins[i] << " |";
         size_t height = (max_bin_count <= MAX_ASTERISK) ? bins[i] : static_cast<size_t>(MAX_ASTERISK * (static_cast<double>(bins[i]) / max_bin_count));
         for (size_t j = 0; j < height; j++) {