code: внесение правок в код

main.cpp

@@ -1,85 +1,74 @@
 #include <iostream>
 #include <vector>
+
 using namespace std;
 
-int main()
+struct Input {
-{
+    vector<double> numbers;
-    const size_t SCREEN_WIDTH = 80;
+    size_t bin_count{};
-    const size_t MAX_ASTERISK = SCREEN_WIDTH - 3 - 1;
+};
 
+Input
+input_data() {
     size_t number_count;
-    cerr << "Enter number count: ";
+    cin >> number_count;
-    cin  >> number_count;
+
-    vector<double> numbers(number_count);
+    Input in;
-    for (size_t i=0;i<number_count;i++){
+    in.numbers.resize(number_count);
-        cin >> numbers[i];
+
+    for (size_t i = 0; i < number_count; i++) {
+        cin >> in.numbers[i];
     }
 
+    cin >> in.bin_count;
 
-    size_t bin_count;
+    return in;
-    cerr << "Enter bin count: ";
+}
-    cin  >> bin_count;
-    vector<size_t> bins(bin_count, 0);
 
-    double min = numbers[0];
+void find_minmax(const vector<double>& numbers, double& min, double& max) {
-    double max = numbers[0];
+    min = numbers[0];
-    for (double x: numbers) {
+    max = numbers[0];
-        if (x<min) {
+    for (double x : numbers) {
+        if (x < min) {
             min = x;
-        }
+        } else if (x > max) {
-        else if (x > max) {
             max = x;
         }
     }
+}
+
+vector<size_t>
+make_histogram(const vector<double>& numbers, size_t bin_count) {
+    double min, max;
+    find_minmax(numbers, min, max);
+
+    vector<size_t> bins(bin_count, 0);
 
     double bin_size = (max - min) / bin_count;
 
-    for(size_t i = 0; i<number_count; i++){
+    for (double number : numbers) {
         bool found = false;
-        for(size_t j=0; (j<bin_count-1) && !found; j++){
+        for (size_t j = 0; (j < bin_count - 1) && !found; j++) {
-            auto lo = min + j*bin_size;
+            double lo = min + j * bin_size;
-            auto hi = min+(j+1)*bin_size;
+            double hi = min + (j + 1) * bin_size;
-            if((lo<= numbers[i]) && (numbers[i] < hi)){
+            if (lo <= number && number < hi) {
                 bins[j]++;
                 found = true;
             }
         }
-        if(!found){
+        if (!found) {
-            bins[bin_count - 1 ]++;
+            bins[bin_count - 1]++;
         }
     }
 
-    size_t max_count = bins[0];
+    return bins;
-    for (size_t i=0;i<bin_count;i++){
+}
-        if (bins[i]>max_count){
-            max_count = bins[i];
-        }
-    }
-
-    for (size_t i = 0; i < bin_count; i++) {
-        if (bins[i] < 10) {
-            cout << "  " << bins[i] << "|";
-        }
-        else if (bins[i] < 100) {
-            cout << " " << bins[i] << "|";
-        }
-        else if (bins[i] < 1000) {
-            cout << bins[i] << "|";
-        }
 
-        size_t height;
-        if (max_count <= MAX_ASTERISK){
-            height = bins[i];
-        }
-        else {
-            height = MAX_ASTERISK*(static_cast<double>(bins[i])/max_count);
-        }
-        for (size_t j=0; j<height;j++){
-            cout << "*";
-        }
-        cout << endl;
-    }
 
-    return 0;
+int
+main() {
+    auto in = input_data();
+    auto bins = make_histogram(in.numbers, in.bin_count);
+    show_histogram_text(bins);
 }