code: Переписал ф-ию input_data и добавил новый параметр prompt

histogram.cpp

@@ -3,8 +3,13 @@
 #include <vector>
 using namespace std;
 
-void find_minmax(const vector<double>& numbers, double& minN, double& maxN)
+//std::vector<size_t>
+bool find_minmax(const vector<double>& numbers, double& minN, double& maxN)
 {
+    if (numbers.empty()) {
+        minN = maxN = 0;
+        return false;
+    }
     minN = numbers[0];
     maxN = numbers[0];
 
@@ -19,6 +24,7 @@ void find_minmax(const vector<double>& numbers, double& minN, double& maxN)
             maxN = x;
         }
     }
+    return true;
 }
 
 vector<size_t> make_histogram(const vector<double>& numbers, size_t bin_count)

histogram_internal.h

@@ -3,7 +3,7 @@
 
 #include <vector>
 
-std::vector<size_t>
-find_minmax( const std::vector<double>& numbers, double& minN, double& maxN);
+//std::vector<size_t>
+bool find_minmax(const std::vector<double>& numbers, double& minN, double& maxN);
 
 #endif // HISTOGRAM_INTERNAL_H_INCLUDED

lab01.cbp

@@ -33,7 +33,20 @@
 			<Add option="-fexceptions" />
 		</Compiler>
 		<Unit filename=".gitignore" />
+		<Unit filename="histogram.cpp" />
+		<Unit filename="histogram.h" />
+		<Unit filename="histogram_internal.h">
+			<Option target="&lt;{~None~}&gt;" />
+		</Unit>
 		<Unit filename="main.cpp" />
+		<Unit filename="svg.cpp" />
+		<Unit filename="svg.h">
+			<Option target="&lt;{~None~}&gt;" />
+		</Unit>
+		<Unit filename="text.cpp" />
+		<Unit filename="text.h">
+			<Option target="&lt;{~None~}&gt;" />
+		</Unit>
 		<Extensions />
 	</Project>
 </CodeBlocks_project_file>

main.cpp

@@ -13,28 +13,37 @@ struct Input
 };
 
 Input
-input_data()
+input_data(istream& in, bool prompt)
 {
-    Input in;
+    Input cin;
+    string numbCntPrmt, numbsPrmt, binCntPrmt;
+    if (prompt == true) {
+        numbCntPrmt = "Enter number count: ";
+        numbsPrmt = "Enter numbers: ";
+        binCntPrmt = "Enter bin count: ";
+    }
     size_t number_count;
-    cin >> number_count;
-    in.numbers.resize(number_count);
+    cerr << numbCntPrmt;
+    in >> number_count;
+    cin.numbers.resize(number_count);
 
     vector<double> numbers(number_count);
 
+    cerr << numbsPrmt;
     for (size_t i = 0; i < number_count; i++)
     {
-        cin >> in.numbers[i];
+        in >> cin.numbers[i];
     }
 
-    cin >> in.bin_count;
-    return in;
+    cerr << binCntPrmt;
+    in >> cin.bin_count;
+    return cin;
 }
 
 int main()
 {
     size_t max_count;
-    auto in = input_data();
+    auto in = input_data(cin, true);
     auto bins = make_histogram(in.numbers, in.bin_count);
     show_histogram_svg(bins);
 }

svg.cpp

@@ -2,7 +2,7 @@
 #include <string>
 using namespace std;
 
-svg_begin(double width, double height) {
+void svg_begin(double width, double height) {
     cout << "<?xml version='1.0' encoding='UTF-8'?>\n";
     cout << "<svg ";
     cout << "width='" << width << "' ";
@@ -19,12 +19,53 @@ void svg_text(double left, double baseline, string text) {
     cout << "<text x='" << left << "' y='" << baseline << "'>" << text << "</text>";
 }
 
+
 void svg_rect(double x, double y, double width, double height, string stroke = "black", string fill = "black")
 {
     cout << "<rect x='" << x << "' y='" << y << "' width='" << width
               << "' height='" << height << "' stroke='" << stroke << "' fill='" << fill << " '/>";
 }
 
+
+
+
+//Çàùèòà
+/*
+void svg_rect(double x, double y, double width, double height, string stroke = "black", string fill = "black", double fill_opacity = 1.0) {
+    cout << "<rect x='" << x << "' y='" << y << "' width='" << width
+         << "' height='" << height << "' stroke='" << stroke
+         << "' fill='" << fill << "' fill-opacity='" << fill_opacity << "'/>";
+}
+
+void show_histogram_svg(const vector<size_t>& bins) {
+    const auto IMAGE_WIDTH = 400;
+    const auto IMAGE_HEIGHT = 300;
+    const auto TEXT_LEFT = 20;
+    const auto TEXT_BASELINE = 20;
+    const auto TEXT_WIDTH = 50;
+    const auto BIN_HEIGHT = 30;
+    const auto BLOCK_WIDTH = 10;
+
+    size_t max_count = *max_element(bins.begin(), bins.end());
+    if (max_count == 0) max_count = 1;
+
+    svg_begin(IMAGE_WIDTH, IMAGE_HEIGHT);
+    double top = 0;
+
+    for (size_t bin : bins) {
+        const double bin_width = min(static_cast<double>(BLOCK_WIDTH * bin), static_cast<double>(IMAGE_WIDTH - TEXT_WIDTH));
+        double opacity = static_cast<double>(bin) / max_count;
+
+        svg_text(TEXT_LEFT, top + TEXT_BASELINE, to_string(bin));
+        svg_rect(TEXT_WIDTH, top, bin_width, BIN_HEIGHT,
+                "blue", "green", opacity);
+        top += BIN_HEIGHT;
+    }
+
+    svg_end();
+}
+*/
+
 void show_histogram_svg(const vector<size_t>& bins) {
     const auto IMAGE_WIDTH = 400;
     const auto IMAGE_HEIGHT = 300;
@@ -46,9 +87,6 @@ void show_histogram_svg(const vector<size_t>& bins) {
         svg_rect(TEXT_WIDTH, top, bin_width, BIN_HEIGHT, "blue", "green");
         top += BIN_HEIGHT;
     }
-
-    //svg_text(20, 20, to_string(bins[0]));
-    //svg_rect(50, 0, bins[0] * 10, 30);
     svg_end();
 }
 

unittest.cbp

@@ -31,6 +31,9 @@
 		<Compiler>
 			<Add option="-Wall" />
 		</Compiler>
+		<Unit filename="histogram.cpp" />
+		<Unit filename="histogram_internal.h" />
+		<Unit filename="unittest.cpp" />
 		<Extensions>
 			<lib_finder disable_auto="1" />
 		</Extensions>

unittest.cpp

@@ -2,6 +2,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "doctest.h"
 #include "histogram_internal.h"
+#include <vector>
 
 TEST_CASE("distinct positive numbers") {
     double min = 0;
@@ -9,7 +10,9 @@ TEST_CASE("distinct positive numbers") {
     find_minmax({1, 2}, min, max);
     CHECK(min == 1);
     CHECK(max == 2);
+    CHECK(find_minmax({1, 2}, min, max));
 }
+
 TEST_CASE("distinct negative numbers")
 {
     double min = 0;
@@ -17,6 +20,7 @@ TEST_CASE("distinct negative numbers")
     find_minmax({-1, -2}, min, max);
     CHECK(min == -2);
     CHECK(max == -1);
+    CHECK(find_minmax({-1, -2}, min, max));
 }
 TEST_CASE("vector 1 element")
 {
@@ -25,4 +29,20 @@ TEST_CASE("vector 1 element")
     find_minmax({1}, min, max);
     CHECK(min == 1);
     CHECK(max == 1);
+    CHECK(find_minmax({1}, min, max));
+}
+TEST_CASE("distinct equals numbers")
+{
+    double min = 0;
+    double max = 0;
+    find_minmax({1, 1}, min, max);
+    CHECK(min == 1);
+    CHECK(max == 1);
+    CHECK(find_minmax({1, 1}, min, max));
+}
+TEST_CASE("distinct empty vector")
+{
+    double min = -1;
+    double max = -1;
+    CHECK(!find_minmax({}, min, max));
 }