code: Структурирование программы при помощи функций

main.cpp

@@ -3,43 +3,143 @@
 
 using namespace std;
 
-int main()
-{
-    const size_t SCREEN_WIDTH = 80;
-    const size_t MAX_ASTERISK = SCREEN_WIDTH - 3 - 1;
-    size_t max_count = 0;
-    size_t max_count_bin;
+struct Input {
+    vector<double> numbers;
+    size_t bin_count{};
+};
+Input
+input_data() {
     size_t number_count;
     cerr << "Enter number count: ";
     cin >> number_count;
-    vector<double> numbers(number_count);
+    Input in;
+    in.numbers.resize(number_count);
     cerr << "Enter numbers: ";
-    for (int i = 0; i < number_count; i++)
-    {
-        cin >> numbers[i];
+    for (size_t i = 0; i < number_count; i++) {
+        cin >> in.numbers[i];
     }
-    size_t bin_count;
     cerr << "Enter bin count: ";
-    cin >> bin_count;
-    vector<size_t > bins(bin_count);
-    double max = numbers[0];
-    double min = numbers[0];
+    cin>> in.bin_count;
+    return in;
+}
+
+
+void
+find_minmax(const vector<double>& numbers, double& min, double& max)
+{
+    min = numbers[0];
+    max = numbers[0];
     for (double x : numbers)
     {
-        if (x > max)
+        if (x > max )
+        {
             max = x;
+        }
         if (x < min)
+        {
             min = x;
-
+        }
     }
-    for (size_t i = 0; i < number_count; i++) {
-        if (numbers[i] < min)
-            min = numbers[i];
-        if (numbers[i] > max)
-            max  = numbers[i];
+}
+vector<size_t>
+make_histogram(const vector<double>& numbers, size_t& bin_count)
+{
+    double min = 0;
+    double max = 0;
+    find_minmax(numbers, min, max);
+    auto bin_size = (max - min)/bin_count;
+    vector<size_t> bins(bin_count);
+    for (double number : numbers)
+    {
+        bool found = false;
+        for (size_t j = 0; (j < bin_count - 1) && !found; j++)
+        {
+            auto lo = min + j * bin_size;
+            auto hi = min + (j + 1) * bin_size;
+            if ((lo <= number) && (number < hi))
+            {
+                bins[j]++;
+                found = true;
+            }
+        }
+        if (!found)
+        {
+            bins[bin_count - 1]++;
+        }
+    }
+    return bins;
+}
+void
+show_histogram_text(const vector<size_t>& bins, size_t& bin_count) {
+    const size_t SCREEN_WIDTH = 80;
+    const size_t MAX_ASTERISK = SCREEN_WIDTH - 3 - 1;
+    size_t max_count = 0;
+    for (size_t s = 0; s < bin_count; s++)
+    {
+        if (bins[s] > max_count)
+        {
+            max_count = bins[s];
+        }
+    }
+    auto kof = static_cast<double>(MAX_ASTERISK) / max_count;
+    if (kof > 1)
+    {
+        kof = 1;
+    }
+    for (size_t bin : bins)
+    {
+        if (bin <100)
+        {
+            cout << " ";
+        }
+        if (bin <10)
+        {
+            cout << " ";
+        }
+        cout << bin << "|";
+        size_t weight = bin * kof;
+        for (size_t t = 0; t < weight; t++)
+        {
+            cout << "*";
+        }
+        cout << endl;
+    }
+}
+int
+main() {
+    auto in = input_data();
+    auto bins = make_histogram(in.numbers, in.bin_count);
+    show_histogram_text(bins, in.bin_count );
+
+/*int main()
+{
+
+    Input in = input_data();
+    double min, max;
+    find_minmax(in.numbers, min, max);
+ cout<< min << " " << max;
+
+
+
+    const size_t SCREEN_WIDTH = 80;
+    const size_t MAX_ASTERISK = SCREEN_WIDTH - 3 - 1;
+    size_t max_count = 0;
+    size_t max_count_bin;
+    size_t number_count;
+    //cerr << "Enter number count: ";
+    //cin >> number_count;
+    //vector<double> numbers(number_count);
+    //cerr << "Enter numbers: ";
+    //for (int i = 0; i < number_count; i++)
+   // {
+    //    cin >> numbers[i];
+   // }
+    //size_t bin_count;
+   // cerr << "Enter bin count: ";
+   // cin >> bin_count;
+//    vector<size_t > bins(bin_count);
 
 
-    }
     double bin_size = ((max - min) / bin_count);
 
     for (size_t i = 0; i < number_count; i++)
@@ -134,6 +234,6 @@ int main()
     {
          cout << "Histogram height is too small";
      }
-
+*/
     return 0;
 }